Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getindex method to LU{Tridiagonal} for extracting factors (and full) #12137

Merged
merged 1 commit into from
Jul 14, 2015
Merged

Add getindex method to LU{Tridiagonal} for extracting factors (and full) #12137

merged 1 commit into from
Jul 14, 2015

Conversation

andreasnoack
Copy link
Member

This one has been missing for a while. Fixes JuliaLang/LinearAlgebra.jl#215, but returns a Matrix because the factors have to be stored as Matrixes. I don't think it is worth the trouble to make full return a Tridiagonal. I've added a specialized full method that returns the original Tridiagonal matrix.

@kshyatt kshyatt added the linear algebra Linear algebra label Jul 13, 2015
@andreasnoack
Add getindex method to LU{Tridiagonal} for extracting factors and full
857b367 
method to reconstruct the Tridiagonal matrix.
@andreasnoack andreasnoack changed the title Add getindex method to LU{Triangular} for extracting factors Add getindex method to LU{Tridiagonal} for extracting factors Jul 14, 2015
@andreasnoack andreasnoack changed the title Add getindex method to LU{Tridiagonal} for extracting factors Add getindex method to LU{Tridiagonal} for extracting factors (and full) Jul 14, 2015
andreasnoack added a commit that referenced this pull request Jul 14, 2015
@andreasnoack
Merge pull request #12137 from JuliaLang/anj/lu
0c2d664 
Add getindex method to LU{Tridiagonal} for extracting factors (and full)
@andreasnoack andreasnoack merged commit 0c2d664 into master Jul 14, 2015
@andreasnoack andreasnoack deleted the anj/lu branch July 14, 2015 14:50
@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2015

full returning a Tridiagonal is a little strange

@andreasnoack
Copy link
Member Author

For factorizations, I think of full as the way of getting the original matrix back. We could consider other names for that.

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2015

convert ?

@andreasnoack
Copy link
Member Author

No because then you'd have to specify a type.

Den tirsdag den 14. juli 2015 skrev Tony Kelman notifications@github.com:

convert ?

—
Reply to this email directly or view it on GitHub
#12137 (comment).

@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2015

That seems like a good thing - the issue here is you've overloaded full with different ambiguous meanings. I think of full as always returning a dense array. This "inverse of factorize" meaning is really a totally separate thing.

@tkelman tkelman mentioned this pull request Jul 14, 2015
Closed
@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2015

opened JuliaLang/LinearAlgebra.jl#229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

full broken for LU{Tridiagonal} via missing getindex(::LU{Tridiagonal}, ::Symbol)
3 participants
@andreasnoack @tkelman @kshyatt